Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#198] 로그아웃시 RefreshToken이 사라지지 않는 현상 해결 #199

Merged
merged 1 commit into from
Nov 23, 2023
Merged

[#198] 로그아웃시 RefreshToken이 사라지지 않는 현상 해결 #199

merged 1 commit into from
Nov 23, 2023

Conversation

Hchanghyeon
Copy link
Member

@Hchanghyeon Hchanghyeon commented Nov 23, 2023 •
edited
Loading

👨‍💻 작업 사항

📑 PR 개요

  • 로그아웃시 쿠키에 담긴 RefreshToken의 Age값을 0으로 변경시킨다.
    • HttpOnly설정으로 인해 클라이언트에서 처리 불가능

✅ 작업 목록

  • 로그아웃 API에 Cookie 값 수명 0으로 변경

🙏 리뷰어에게

API endpoint

  • DELETE /auth/logout

Prefix

PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.

  • P1: 꼭 반영해주세요 (Request changes)
  • P2: 적극적으로 고려해주세요 (Request changes)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@Hchanghyeon Hchanghyeon added the 버그 [fix] 에러를 해결하거나, 잘못된 결과를 수정한다. label Nov 23, 2023
@Hchanghyeon Hchanghyeon added this to the 5차 스프린트 milestone Nov 23, 2023
@Hchanghyeon Hchanghyeon requested a review from a team November 23, 2023 12:29
@Hchanghyeon Hchanghyeon self-assigned this Nov 23, 2023
@Hchanghyeon Hchanghyeon requested review from kylekim2123 and charlesuu and removed request for a team November 23, 2023 12:29
@Hchanghyeon Hchanghyeon marked this pull request as ready for review November 23, 2023 12:30
@Hchanghyeon Hchanghyeon linked an issue Nov 23, 2023 that may be closed by this pull request
[회원] 로그아웃시 RefreshToken이 사라지지 않는 현상 #198
Closed
1 task
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

@Hchanghyeon Hchanghyeon merged commit c203a98 into dev Nov 23, 2023
3 checks passed
@Hchanghyeon Hchanghyeon deleted the feature/#198 branch November 23, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekim2123 kylekim2123 kylekim2123 approved these changes

@charlesuu charlesuu Awaiting requested review from charlesuu

Assignees

@Hchanghyeon Hchanghyeon

Labels
버그 [fix] 에러를 해결하거나, 잘못된 결과를 수정한다.
Projects
None yet
Milestone
5차 스프린트
Development

Successfully merging this pull request may close these issues.

[회원] 로그아웃시 RefreshToken이 사라지지 않는 현상
2 participants
@Hchanghyeon @kylekim2123