Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#247] 지도에서 종료된 게스트 모집글을 불러오는 현상 해결 #248

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[#247] 지도에서 종료된 게스트 모집글을 불러오는 현상 해결 #248

merged 1 commit into from
Nov 30, 2023

Conversation

Hchanghyeon
Copy link
Member

👨‍💻 작업 사항

📑 PR 개요

  • 지도에서 게스트 모집글을 불러올 때 경기가 종료되지 않은 데이터만 불러올 수 있도록 수정한다.

✅ 작업 목록

  • isNotEndedGame 메서드를 filter에 추가

🙏 리뷰어에게

기타

Prefix

PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.

  • P1: 꼭 반영해주세요 (Request changes)
  • P2: 적극적으로 고려해주세요 (Request changes)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@Hchanghyeon Hchanghyeon added the 버그 [fix] 에러를 해결하거나, 잘못된 결과를 수정한다. label Nov 30, 2023
@Hchanghyeon Hchanghyeon added this to the 6차 스프린트 milestone Nov 30, 2023
@Hchanghyeon Hchanghyeon requested a review from a team November 30, 2023 11:01
@Hchanghyeon Hchanghyeon self-assigned this Nov 30, 2023
@Hchanghyeon Hchanghyeon requested review from kylekim2123 and jay-so and removed request for a team November 30, 2023 11:01
@Hchanghyeon Hchanghyeon linked an issue Nov 30, 2023 that may be closed by this pull request
[지도] 지도에서 종료된 게스트 모집글을 불러오는 현상 해결 #247
Closed
1 task
@Hchanghyeon Hchanghyeon marked this pull request as ready for review November 30, 2023 11:01
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Hchanghyeon Hchanghyeon merged commit 6b04fc3 into dev Nov 30, 2023
@Hchanghyeon Hchanghyeon deleted the feature/#247 branch November 30, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekim2123 kylekim2123 kylekim2123 approved these changes

@jay-so jay-so Awaiting requested review from jay-so

Assignees

@Hchanghyeon Hchanghyeon

Labels
버그 [fix] 에러를 해결하거나, 잘못된 결과를 수정한다.
Projects
None yet
Milestone
6차 스프린트
Development

Successfully merging this pull request may close these issues.

[지도] 지도에서 종료된 게스트 모집글을 불러오는 현상 해결
2 participants
@Hchanghyeon @kylekim2123