[#243] Spring Batch를 사용한 게스트 모집 글 상태 변경 자동화 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hchanghyeon
requested review from
a team,
kylekim2123 and
jay-so
and removed request for
a team
5 tasks
Hchanghyeon
commented
Dec 1, 2023
Comment on lines
24
to
33
| public Job job( | ||
| final JobRepository jobRepository, | ||
| final Step updateGameStatusToClosedStep, | ||
| final Step updateGameStatusToEndedStep | ||
| ) { | ||
| return new JobBuilder("updateGameStatus", jobRepository) | ||
| .start(updateGameStatusToClosedStep) | ||
| .next(updateGameStatusToEndedStep) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
하나의 Job을 의미하며
.start()에 들어가는 Step은 게임 상태를 모집 중 -> 모집 마감으로 변경하는 Step이고
.next()에 들어가는 Step은 게임 상태를 모집 마감 -> 경기 종료로 변경하는 Step입니다.
한마디로 하나의 Job안에 2개의 Step이 들어있고 .start()를 이용하여 첫번째 Step을 진행하고 .next()를 이용하여 두번째 Step이 진행됩니다!
Hchanghyeon
commented
Dec 1, 2023
Comment on lines
35
to
43
| @Bean | ||
| public Tasklet gameClosedTasklet() { | ||
| return new GameClosedTasklet(gameRepository); | ||
| } | ||
|
|
||
| @Bean | ||
| public Tasklet gameEndedTasklet() { | ||
| return new GameEndedTasklet(gameRepository); | ||
| } |
There was a problem hiding this comment.
Tasklet 객체는 Step에 사용되는 실제로 배치 작업을 수행하는 객체 입니다.
Hchanghyeon
commented
Dec 1, 2023
Comment on lines
26
to
43
| @Scheduled(cron = "0 0/30 * * * *") | ||
| public void runJob() { | ||
| try { | ||
| jobLauncher.run( | ||
| job, | ||
| new JobParametersBuilder() | ||
| .addString("dateTime", LocalDateTime.now().toString()) | ||
| .toJobParameters() | ||
| ); | ||
| } catch ( | ||
| JobExecutionAlreadyRunningException | | ||
| JobInstanceAlreadyCompleteException | | ||
| JobParametersInvalidException | | ||
| JobRestartException e | ||
| ) { | ||
| log.error("[Scheduler - Batch] run job exception: ", e); | ||
| } | ||
| } |
There was a problem hiding this comment.
매 30분마다 jobLauncher에 의해 설정 해둔 Job이 수행됩니다.
Hchanghyeon
changed the title
charlesuu
approved these changes
Dec 1, 2023
hanjo8813
reviewed
Dec 1, 2023
Comment on lines
17
to
20
| public class BatchConfig extends DefaultBatchConfiguration { | ||
|
|
||
| @Bean | ||
| public Job job( |
There was a problem hiding this comment.
현재는 job이 하나지만, 여러개로 늘어날 가능성을 고려해 네이밍하면 좋을것 같아요
BatchConfig -> 어쩌구BatchConfig
그리고 job bean도 중복될수 있으니 name 파라미터나 메소드명으로 네이밍 신경쓰기~!
There was a problem hiding this comment.
말씀하신대로 확장 가능성을 고려하여 Class 파일명, 메서드명 모두 수정했습니다! 감사합니다 👍👍
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👨💻 작업 사항
📑 PR 개요
✅ 작업 목록
🙏 리뷰어에게
Prefix
P1: 꼭 반영해주세요 (Request changes)P2: 적극적으로 고려해주세요 (Request changes)P3: 웬만하면 반영해 주세요 (Comment)P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)P5: 그냥 사소한 의견입니다 (Approve)