Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#249] 크루 랭킹의 캐시 저장소 변경, 캐싱 스케줄러의 중복 실행 방지 #266

Merged
merged 2 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ dependencies {
implementation 'org.springframework.boot:spring-boot-starter-cache'
implementation "com.github.ben-manes.caffeine:caffeine:3.1.8"
implementation 'org.hibernate:hibernate-spatial:6.3.1.Final'
implementation 'org.redisson:redisson-spring-boot-starter:3.23.4'

implementation group: 'org.flywaydb', name: 'flyway-mysql', version: '9.10.2'
implementation 'org.springframework.boot:spring-boot-starter-webflux'
Expand Down
35 changes: 35 additions & 0 deletions src/main/java/kr/pickple/back/common/config/CacheConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,25 @@
import java.util.List;
import java.util.concurrent.TimeUnit;

import org.redisson.Redisson;
import org.redisson.api.RedissonClient;
import org.redisson.config.Config;
import org.springframework.cache.CacheManager;
import org.springframework.cache.annotation.EnableCaching;
import org.springframework.cache.caffeine.CaffeineCache;
import org.springframework.cache.support.SimpleCacheManager;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Primary;
import org.springframework.data.redis.cache.RedisCacheConfiguration;
import org.springframework.data.redis.cache.RedisCacheManager;
import org.springframework.data.redis.connection.RedisConnectionFactory;
import org.springframework.data.redis.connection.RedisStandaloneConfiguration;
import org.springframework.data.redis.connection.lettuce.LettuceConnectionFactory;
import org.springframework.data.redis.core.RedisTemplate;
import org.springframework.data.redis.serializer.GenericJackson2JsonRedisSerializer;
import org.springframework.data.redis.serializer.Jackson2JsonRedisSerializer;
import org.springframework.data.redis.serializer.RedisSerializationContext;
import org.springframework.data.redis.serializer.StringRedisSerializer;

import com.fasterxml.jackson.databind.ObjectMapper;
Expand All @@ -34,6 +42,7 @@ public class CacheConfig {
private final RedisProperties redisProperties;

@Bean
@Primary
public CacheManager caffeineCacheManager() {
final List<CaffeineCache> caches = Arrays.stream(CacheType.values())
.map(cacheType ->
Expand All @@ -52,6 +61,32 @@ public CacheManager caffeineCacheManager() {
return cacheManager;
}

@Bean
public CacheManager redisCacheManager() {
RedisCacheConfiguration redisCacheConfiguration = RedisCacheConfiguration.defaultCacheConfig()
.serializeKeysWith(RedisSerializationContext.SerializationPair
.fromSerializer(new StringRedisSerializer()))
.serializeValuesWith(RedisSerializationContext.SerializationPair
.fromSerializer(new Jackson2JsonRedisSerializer(Object.class)));

return RedisCacheManager.RedisCacheManagerBuilder
.fromConnectionFactory(redisConnectionFactory())
.cacheDefaults(redisCacheConfiguration)
.build();
}

@Bean
public RedissonClient redissonClient() {
Config redisConfig = new Config();
redisConfig.useSingleServer()
.setAddress(String.format("redis://%s:%d", redisProperties.getHost(), redisProperties.getPort()))
.setPassword(redisProperties.getPassword())
.setConnectionMinimumIdleSize(2)
.setConnectionPoolSize(4);

return Redisson.create(redisConfig);
}

@Bean
public RedisConnectionFactory redisConnectionFactory() {
final RedisStandaloneConfiguration redisStandaloneConfiguration = new RedisStandaloneConfiguration();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package kr.pickple.back.ranking.service;

import org.redisson.api.RLock;
import org.redisson.api.RedissonClient;
import org.springframework.scheduling.annotation.Scheduled;
import org.springframework.stereotype.Component;

Expand All @@ -10,9 +12,17 @@
public class RankingScheduler {

private final RankingService rankingService;
private final RedissonClient redissonClient;

@Scheduled(cron = "0 0 */6 * * *")
public void refreshRankingCache() {
rankingService.putCrewRankingCache();
RLock lock = redissonClient.getLock("refreshCrewRankingCacheLock");
if (lock.tryLock()) {
try {
rankingService.putCrewRankingCache();
} finally {
lock.unlock();
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ public class RankingService {

private final RankingJdbcRepository rankingJdbcRepository;

@Cacheable(cacheManager = "caffeineCacheManager", cacheNames = "ranking", key = "'crew'")
@Cacheable(cacheManager = "redisCacheManager", cacheNames = "ranking", key = "'crew'")
public List<CrewRankingResponse> findCrewRanking() {
return putCrewRankingCache();
}

@CachePut(cacheManager = "caffeineCacheManager", cacheNames = "ranking", key = "'crew'")
@CachePut(cacheManager = "redisCacheManager", cacheNames = "ranking", key = "'crew'")
public List<CrewRankingResponse> putCrewRankingCache() {
final List<CrewRankingResponse> crewRankings = rankingJdbcRepository.getCrewRankings();

Expand Down