Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[크루] Crew 도메인 Address 관련 단방향 연관관계 제거 #287

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

kylekim2123
Copy link
Member

👨‍💻 작업 사항

📑 PR 개요

  • Crew 도메인 Address 관련 단방향 연관관계를 한다.

✅ 작업 목록

  • Crew 엔티티 내의 AddressDepth1, AddressDepth2의 ManyToOne 연관관계 제거
  • AddressReader에서 id를 통해 조회하는 로직 작성

Prefix

PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.

  • P1: 꼭 반영해주세요 (Request changes)
  • P2: 적극적으로 고려해주세요 (Request changes)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@kylekim2123 kylekim2123 added the 리팩토링 [refactor] 실행 결과는 동일하고, 코드 구조만 변경한다. label Feb 7, 2024
@kylekim2123 kylekim2123 self-assigned this Feb 7, 2024
@kylekim2123 kylekim2123 changed the base branch from dev to refactoring February 7, 2024 14:49
@kylekim2123 kylekim2123 merged commit 07441ac into refactoring Feb 8, 2024
1 check failed
@kylekim2123 kylekim2123 deleted the crew-refactoring branch February 8, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
리팩토링 [refactor] 실행 결과는 동일하고, 코드 구조만 변경한다.
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

2 participants