Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validators): implement shell support #37

Merged
merged 2 commits into from
Feb 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 41 additions & 7 deletions verified_cogen/runners/validating.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from abc import ABC, abstractmethod
from subprocess import CalledProcessError, run
from typing import List, Optional

from verified_cogen.llm import prompts
Expand All @@ -7,8 +9,44 @@
from verified_cogen.tools.modes import Mode


class Validator(ABC):
@abstractmethod
def add_validators(self, prg: str, inv_prg: str) -> str: ...


class LanguageValidator(Validator):
language: Language
remove_helpers: bool

def __init__(self, language: Language, remove_helpers: bool):
self.language = language
self.remove_helpers = remove_helpers

def add_validators(self, prg: str, inv_prg: str) -> str:
validators = self.language.generate_validators(prg, not self.remove_helpers)
comment = self.language.simple_comment
val_prg = inv_prg + "\n" + comment + " ==== verifiers ==== \n" + validators
return val_prg


class ShellValidator(Validator):
cli_command: list[str]

def __init__(self, cli_command: list[str]):
self.cli_command = cli_command

def add_validators(self, prg: str, inv_prg: str) -> str:
try:
command = self.cli_command + [prg, inv_prg]
result = run(command, capture_output=True, timeout=10, check=True).stdout.decode()
return result
except (CalledProcessError, TimeoutError):
return inv_prg


class ValidatingRunner(Runner):
wrapped_runner: Runner
validator: Validator
language: Language
summarizer_llm: LLM
pure_non_helpers: List[str]
Expand All @@ -17,6 +55,7 @@ def __init__(
self,
wrapping: Runner,
language: Language,
validator: Optional[Validator] = None,
):
super().__init__(wrapping.llm, wrapping.logger, wrapping.verifier, wrapping.config)
token = wrapping.llm.grazie._grazie_jwt_token # type: ignore
Expand All @@ -29,15 +68,10 @@ def __init__(
temperature=0.3,
)
self.wrapped_runner = wrapping
self.validator = validator or LanguageValidator(language, self.config.remove_helpers)
self.language = language
self.pure_non_helpers = []

def _add_validators(self, prg: str, inv_prg: str):
validators = self.language.generate_validators(prg, not self.config.remove_helpers)
comment = self.language.simple_comment
val_prg = inv_prg + "\n" + comment + " ==== verifiers ==== \n" + validators
return val_prg

def preprocess(self, prg: str, mode: Mode) -> str:
if self.config.remove_implementations and not self.config.remove_helpers:
self.pure_non_helpers = self.language.find_pure_non_helpers(prg)
Expand All @@ -64,7 +98,7 @@ def postprocess(self, inv_prg: str) -> str:
.replace("{helpers}", ",".join(self.pure_non_helpers))
)
self.llm.add_response("understood")
return self._add_validators(self.starting_prg, self.wrapped_runner.postprocess(inv_prg))
return self.validator.add_validators(self.starting_prg, self.wrapped_runner.postprocess(inv_prg))

def rewrite(
self,
Expand Down