components[splitePane]: Feat: Add option to hide first pane in SplitPane #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to hide the first pane in a SplitPane. - Adds `firstVisible ` property to `SplitPaneState` to control the visibility of the first pane. - Updates `SplitPane` layout to handle the visibility of the first pane. - Adds buttons to the demo to toggle the visibility of the first pane.
Improved the button labels in the SplitPane demo to be more descriptive. "Hide V First" and "Show V First" are now "Hide Left Pane" and "Show Left Pane". "Hide H First" and "Show H First" are now "Hide Top Pane" and "Show Top Pane".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces the ability to dynamically hide the first pane within a SplitPane composable. This is achieved through a new
firstVisibleproperty inSplitPaneState, allowing developers to control pane visibility. The layout logic ofSplitPanehas been updated to accommodate this feature.Testing
The changes have been tested by adding interactive buttons to the demo application, enabling users to toggle the visibility of the first pane and observe the resulting behavior.
Release Notes
Features
firstVisibleproperty toSplitPaneStateto control the visibility of the first pane in aSplitPane.Fixes
2024-07-01.03-29-13.mp4