Add hyperlinks of stack traces in Laravel logs #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pestretsov
requested changes
Jun 29, 2023
| } | ||
|
|
||
| private fun buildFileHyperlinkInfo(fileUri: String): HyperlinkInfo? { | ||
| var documentLine = 0 |
There was a problem hiding this comment.
It's always a better idea to declare variables as close to their first usage as possible. Also, let's avoid using vars when they are not needed
val documentLine = if (possibleDocumentLine != Int.MIN_VALUE) possibleDocumentLine - 1 else possibleDocumentLine
src/main/kotlin/com/intellij/ideolog/filters/LaravelStackTraceFileFilter.kt
Show resolved
Hide resolved
|
|
||
| override fun applyFilter(line: String, entireLength: Int): Filter.Result? { | ||
| val textStartOffset = entireLength - line.length | ||
| val items = collectItems(textStartOffset, LINUX_MACOS_FILE_PATTERN.matcher(line)) + |
There was a problem hiding this comment.
items and collectItems are kinda too generic names, right?
|
|
||
| override fun applyFilter(line: String, entireLength: Int): Filter.Result? { | ||
| val textStartOffset = entireLength - line.length | ||
| val items = collectItems(textStartOffset, LINUX_MACOS_FILE_PATTERN.matcher(line)) + |
There was a problem hiding this comment.
Performance: we probably should add some kind of fast check that line is not Url to avoid checking regexps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for hyperlinks in the Laravel log stacktrace.
In the case Laravel logs, the position in the file is specified in parentheses:
While the default format expected the number after the semicolon:
The feature is tested on file URI for Windows, Linux, and MacOS.
Before:
After: