Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better highlighting #166

Closed
wants to merge 0 commits into from

Conversation

ArtemKar123
Copy link
Collaborator

Features

This PR adds two fields to highlighting settings:

  1. Capture group — now you can choose a specific capture group to be matched before applying regexp and highlighting. Leave 0 to match all groups.
  2. Format — you can choose a specific parsing format for the highlighting. Leave Any to match all formats.
    telegram-cloud-photo-size-2-5433870560384898882-x

Motivation

Previously highlighting would highlight anything matching the pattern, that would lead to issues like this one.
Here we use the default Error pattern and it works ok with IDEA format, but leads to somewhat strange in a custom one:
telegram-cloud-photo-size-2-5433870560384898868-y

How it works now

telegram-cloud-photo-size-2-5433870560384898882-x
telegram-cloud-photo-size-2-5433870560384898880-x
telegram-cloud-photo-size-2-5433870560384898879-y

@mfilippov mfilippov self-requested a review December 5, 2023 06:48
Copy link
Collaborator

@mfilippov mfilippov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants