Reuse filesystem accessed by different uri to the same file #1201
+50
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a jar file was opened with different uris pointing to the same file they would return the same file system because the jdk normalizes the uri, eg jar:file:/tmp/../tmp/file.jar becomes jar:file:/tmp/file.jar. Therefore the number of users of one filesystem was incorrect and it might have been closed while still in use. This occured eg. in mono repos with multiple intellij plugins and parallel builds.
|
Sorry, I somehow completely missed the other tests. I fixed the failing ones and made sure that a |
|
This is a very nice catch and an improvement! Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a jar file was opened with different uris pointing to the same file they would return the same file system because the jdk normalizes the uri, eg jar:file:/tmp/../tmp/file.jar becomes jar:file:/tmp/file.jar.
Therefore the number of users of one filesystem was incorrect and it might have been closed while still in use.
This occured eg. in mono repos with multiple intellij plugins and parallel builds.