Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IJP 24.1 #290

Merged
merged 12 commits into from
Jan 31, 2024
Merged

Add support for IJP 24.1 #290

merged 12 commits into from
Jan 31, 2024

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Jan 30, 2024

This PR implements initial support for the IntelliJ Platform 24.1. It also:

  • Bumps the 233 dependency to 233.3
  • Adds setup instructions to the README
  • Updates a number of dependencies
  • Cleans up the build scripts
  • Adds 241 tasks to the CI
  • Builds the standalone themes based on 241

To note, running the ide-plugin sample as-is in 241 will crash. This is because Jewel is bundled in 241, but it's an older version, and that breaks in all sorts of fun ways. The only known workaround for now is shadowing everything.

@rock3r rock3r added bridge Something that impacts the Swing LaF bridge maintenance Rote maintenance tasks (e.g., dependency updates) labels Jan 30, 2024
@rock3r rock3r self-assigned this Jan 30, 2024
Copy link
Collaborator

@fscarponi fscarponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am quite confident that the PR can be shipped, I would suggest waiting for the release of 241 stable. Later if we don't need to create a new bridge to compensate for the differences, I would reconsider the bridge naming (to help the user with a more intuitive approach)

@rock3r
Copy link
Collaborator Author

rock3r commented Jan 31, 2024

@fscarponi what exactly do you think is a blocker that requires waiting for 241 stable in this PR? There isn't any new logic or 241-specific code in Jewel, it's mostly about the build

@rock3r
Copy link
Collaborator Author

rock3r commented Jan 31, 2024

Note: talked online about this and the worries are mostly about 241 changing LaF keys and values again, but this still seems to work fine for now, at least in the IDE.

@rock3r rock3r marked this pull request as draft January 31, 2024 15:05
@rock3r rock3r marked this pull request as ready for review January 31, 2024 15:52
@rock3r
Copy link
Collaborator Author

rock3r commented Jan 31, 2024

There are some breakages in standalone due to significative changes in how SVGs are patched in 241 — I will address them in a separate PR.

@rock3r rock3r merged commit 22ec6c9 into main Jan 31, 2024
16 checks passed
@rock3r rock3r deleted the 241-support branch January 31, 2024 15:53
rock3r added a commit that referenced this pull request Feb 12, 2024
Includes relevant changes from these PRs:
#290 — Add support for 241
#292 — Switch to the new branching strategy
#293 — Fix icon loading and errors in bridge for 241
#294 — Add Markdown renderer code and sample
@rock3r rock3r mentioned this pull request Feb 12, 2024
rock3r added a commit that referenced this pull request Feb 12, 2024
Includes relevant changes from these PRs:
#290 — Add support for 241
#292 — Switch to the new branching strategy
#293 — Fix icon loading and errors in bridge for 241
#294 — Add Markdown renderer code and sample
@rock3r rock3r mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge Something that impacts the Swing LaF bridge maintenance Rote maintenance tasks (e.g., dependency updates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants