-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IJP 24.1 #290
Conversation
This updates the readme with setup instructions and an IJP to bridge version table, too. As a bonus, we also bump 233 to the latest 233.3 version.
This prepares us for when we'll need to support the upcoming JDK 21
(this causes the API signatures to change!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am quite confident that the PR can be shipped, I would suggest waiting for the release of 241 stable. Later if we don't need to create a new bridge to compensate for the differences, I would reconsider the bridge naming (to help the user with a more intuitive approach)
@fscarponi what exactly do you think is a blocker that requires waiting for 241 stable in this PR? There isn't any new logic or 241-specific code in Jewel, it's mostly about the build |
Note: talked online about this and the worries are mostly about 241 changing LaF keys and values again, but this still seems to work fine for now, at least in the IDE. |
There are some breakages in standalone due to significative changes in how SVGs are patched in 241 — I will address them in a separate PR. |
This PR implements initial support for the IntelliJ Platform 24.1. It also:
To note, running the ide-plugin sample as-is in 241 will crash. This is because Jewel is bundled in 241, but it's an older version, and that breaks in all sorts of fun ways. The only known workaround for now is shadowing everything.