Use chars instead of lines indexes #679
Conversation
obask
force-pushed
the
use-input-index-for-fast-edits
branch
from
51850ee to
2347290
Compare
There was a problem hiding this comment.
[GitHub user error on my end], but I added a comment on your commit at instead of the comment on your PR: 2347290#diff-67e63e6b07196973eeae520d175d19e0bc5b602c5d8f8c8c7ae3b10a80c20857R83
Let me know what you think.
Sounds good, thanks for your suggestions! Much of the code structure reflects the unit tests, which is not ideal. I plan to modify the tests to assert against data classes while splitting logic into more fine-grained sub-functions, which should reduce complexity. |
|
@obask planning to get this into 0.27? If so the deadline is tomorrow :) |
Our previouis version was marking a previouis and the following blocks as modified, while it's not needed in most cases. We can use use 0.24.0 inputIndex parameter to simply keep an index from char to block and avoid splitting lines and doing complicated search for a modified substring.
hamen
force-pushed
the
use-input-index-for-fast-edits
branch
from
2347290 to
bc595b2
Compare
I may try to convert tests to data classes, but won't refactor the rest before "the merge" |
Our previouis version was marking a previouis
and the following blocks as modified, while it's
not needed in most cases.
We can use use 0.24.0 inputIndex parameter to
simply keep an index from char to block and avoid
splitting lines and doing complicated search for
a modified substring.