[REVIEW ONLY] - Reallocate styles in appropriate files #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Morgillo <[email protected]>
rock3r
reviewed
Dec 6, 2024
| import org.jetbrains.jewel.ui.component.styling.ButtonMetrics | ||
| import org.jetbrains.jewel.ui.component.styling.ButtonStyle | ||
|
|
||
| internal fun readOutlinedButtonStyle(): ButtonStyle { |
There was a problem hiding this comment.
Outlined and Default are both Button types. They should stay in the same file (IntUiBridgeButton)
| import org.jetbrains.jewel.ui.component.styling.TabStyle | ||
| import org.jetbrains.jewel.ui.icons.AllIconsKeys | ||
|
|
||
| internal fun readEditorTabStyle(): TabStyle { |
There was a problem hiding this comment.
Default and Editor are both Tab styles. They should stay in the same file (IntUiBridgeTab)
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
rock3r
approved these changes
Dec 6, 2024
hamen
added a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 14, 2025
Reference JetBrains/jewel#713 Signed-off-by: Ivan Morgillo <[email protected]>
|
Migrated to IJP as JetBrains/intellij-community#2910 |
intellij-monorepo-bot
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
Jan 15, 2025
Reference JetBrains/jewel#713 Signed-off-by: Ivan Morgillo <[email protected]> closes #2910 GitOrigin-RevId: 1deb160659741c2256d49ace9460a515f504384f
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Reference #713 Signed-off-by: Ivan Morgillo <[email protected]> closes JetBrains/intellij-community#2910 GitOrigin-RevId: 1deb160659741c2256d49ace9460a515f504384f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #708