Add start screens, privacy policy and notification onboarding #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsmb13
commented
Jan 14, 2025
Comment on lines
-25
to
-27
| May22(Res.string.day_1), | ||
| May23(Res.string.day_2), | ||
| May24(Res.string.day_3); |
There was a problem hiding this comment.
Removing these hardcoded day strings for now. We should see if these can be computed more reasonably from the backend data.
There was a problem hiding this comment.
Sometimes formatting of days is changed in the sessionize for the website requirements, so we need to compute this from the actual sessions timestamps
zsmb13
changed the title
e5l
approved these changes
Jan 15, 2025
Comment on lines
-25
to
-27
| May22(Res.string.day_1), | ||
| May23(Res.string.day_2), | ||
| May24(Res.string.day_3); |
There was a problem hiding this comment.
Sometimes formatting of days is changed in the sessionize for the website requirements, so we need to compute this from the actual sessions timestamps
kropp
approved these changes
Jan 15, 2025
shared/src/commonMain/kotlin/org/jetbrains/kotlinconf/screens/StartScreens.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
Screen.Recording.2025-01-15.at.0.44.53.mov