Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SSH.NET version to 2024.0.0 and target newer frameworks #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dHamburgler
Copy link

  • Use SSH.NET 2024.0.0
  • Minor code changes needed for the above version
  • Fix broken license tag + file

BREAKING CHANGE:

  • Dropped support for universal windows platform (SSH.NET no longer supports it). However netstandard2.0 can also be used

@ctrlaltf24
Copy link

@JohnTheGr8 Would it be possible to review this? SSH.NET that this project currently uses (from 2016) doesn't support rsa-sha2-*

@@ -1,47 +1,30 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard1.3;net40;uap10.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net462;</TargetFrameworks>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some modern target framework could be also added? .NET 8 ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants