En dk #1
Closed
En dk #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonBendtsen
pushed a commit
that referenced
this pull request
Nov 8, 2023
…6180) Fixes the following error: PHP Fatal error: Uncaught Exception: Serialization of PgSql\Connection is not allowed in /var/www/html/core/lib/functions.lib.php:1168 Stack trace: #0 /var/www/html/core/lib/functions.lib.php(1168): serialize() #1 /var/www/html/compta/facture/card.php(2798): dol_clone() Dolibarr#2 {main}
JonBendtsen
pushed a commit
that referenced
this pull request
Jan 20, 2024
…n-in-setup-module Update actions_setmoduleoptions.inc.php
JonBendtsen
pushed a commit
that referenced
this pull request
Feb 10, 2024
htdocs/salaries/class/salariesstats.class.php 100 Parameter #1 $year (string) of method SalariesStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
JonBendtsen
pushed a commit
that referenced
this pull request
Feb 10, 2024
….php htdocs/expensereport/class/expensereportstats.class.php 113 Parameter #1 $year (string) of method ExpenseReportStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
JonBendtsen
pushed a commit
that referenced
this pull request
Feb 10, 2024
* Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Qual: Introduce getDataToShowPhoto to prepare generic code * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Fix missing trans * Fix langs * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Remove useless files in web templates * Clean code * Fix duplicate translation key * Fix duplicate translation key * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Fix duplicate key * Fix $object * Debug v19 * WIP SMSing * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * WIP EMAILINGS_SUPPORT_ALSO_SMS * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * WIP SMSing * Debug the "validate" feature * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Clean code * Move rights->x->y into hasRight('x', 'y') * Move rights->x->y into hasRight('x', 'y') * Move rights->x->y into hasRight('x', 'y') * Move rights->x->y into hasRight('x', 'y') * Move rights->x->y into hasRight('x', 'y') * Move rights->x->y into hasRight('x', 'y') * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Enhance rector to fix empty($user->rights->modulex->perm1) * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Fix template to use v19 dev rules * Fix use v19 dev rules * Fix phpunit * Debug v19 * Clean code * Use rector to convert user->rights into user->hasRight * Clean code * Use rector to convert user->rights into user->hasRight * Use rector to convert user->rights into user->hasRight * Clean code * Fix phpcs * add editorconfig for sql files (Dolibarr#27999) Co-authored-by: Laurent Destailleur <[email protected]> * add model_pdf field in llx_ticket-ticket.sql (Dolibarr#27996) * add model_pdf field in llx_ticket-ticket.sql * Update 19.0.0-20.0.0.sql * Update 19.0.0-20.0.0.sql * Improve wording in README (Dolibarr#27994) * fix phpstan (Dolibarr#27989) * fix phpstan * Update UserRightsToFunction.php --------- Co-authored-by: Laurent Destailleur <[email protected]> * Qual: Fix spelling/working in datapolicy translations (Dolibarr#28006) # Qual: Fix spelling/wording in datapolicy translations Fixed some spelling and wording in datapolicy translations. * qual: phpstan for htdocs/ticket/class/ticketstats.class.php (Dolibarr#27986) htdocs/ticket/class/ticketstats.class.php 98 Parameter #1 $year (string) of method TicketStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth() * Merge branch '19.0' of [email protected]:Dolibarr/dolibarr.git into develop * Fix user with readonly perm on email template must be able to read. * Fix doc * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Better message * Add missing fields in merge of thirdparty * Debug v19 selection of ticket printer per terminal * Merge branch 'develop' of [email protected]:Dolibarr/dolibarr.git into develop * Use constant * NEW: Adding a recipient on emails sent, change status to sent partialy. * fix travis (Dolibarr#28052) * fix travis * Update partnership.class.php * fix php doc (Dolibarr#28047) * fix undefined array key (Dolibarr#28048) * Add region and departament for Cuba (Dolibarr#28046) * Update llx_10_c_regions.sql Add Cuba Regions (id_country=77) * Update llx_20_c_departements.sql Add Provinces Cuba (id country=77) * Find the typo (Dolibarr#28050) * Find the typo * clean code * add last_main_doc field to product (Dolibarr#28045) * add las_main_doc field to product * add field fetch * NEW Add Categorie filter for ActionComm (Dolibarr#28041) * New Add Categorie filter for ActionComm New Add Categorie filter for ActionComm * Fix space errors Fix space errors * Fix space errors 2 Fix space errors 2 * Update cunits.class.php (Dolibarr#28056) FIX: error SQL when creating a Cunit * Update codespell-lines-ignore.txt to avoid PR merge conflict --------- Co-authored-by: Laurent Destailleur <[email protected]> Co-authored-by: Frédéric FRANCE <[email protected]> Co-authored-by: thibdrev <[email protected]> Co-authored-by: sonikf <[email protected]> Co-authored-by: Ikarus <[email protected]> Co-authored-by: Anthony Damhet <[email protected]> Co-authored-by: Quentin-Seekness <[email protected]>
JonBendtsen
pushed a commit
that referenced
this pull request
Feb 10, 2024
…converted to string in /srv/users/dolibarr/apps/dolibarr/htdocs/core/modules/societe/mod_codecompta_aquarium.php:98 Stack trace: #0 /srv/users/dolibarr/apps/dolibarr/htdocs/societe/admin/societe.php(495): mod_codecompta_aquarium->info(Object(Translate)) #1 {main} thrown in /srv/users/dolibarr/apps/dolibarr/htdocs/core/modules/societe/mod_codecompta_aquarium.php on line 98 (Dolibarr#28093)
JonBendtsen
pushed a commit
that referenced
this pull request
Feb 14, 2024
…ass.php (Dolibarr#28149) htdocs/compta/deplacement/class/deplacementstats.class.php 101 Parameter #1 $year (string) of method DeplacementStats::getNbByMonth() should be compatible with parameter $year (int) of method Stats::getNbByMonth()
eldy
pushed a commit
that referenced
this pull request
Feb 24, 2024
# Fix: Spelling, PHan warnings, preg quoting, array size Initial reasons: website.class.php: PhanPluginSuspiciousParamOrder: Suspicious order for arguments named pathofwebsiteold and pathofwebsitenew - These are being passed to parameters #1 (string $srcfile) and Dolibarr#2 (string $destfile) of \dolCopyDir(string $srcfile, string $destfile, string $newmask, int $overwriteifexists, array<string,string> $arrayreplacement = null, int $excludesubdir = 0, string[] $excludefileext = null) defined at htdocs/core/lib/files.lib.php:871 Warning: website.class.php: PhanTypeArraySuspiciousNull: Suspicious array access to $linefound[1] of type null Warning: website.class.php: PhanTypeArraySuspiciousNull: Suspicious array access to $linefound[1] of type null Also fixed spelling, added preg_quote, fixed spelling for several comments and variables
eldy
pushed a commit
that referenced
this pull request
Apr 3, 2024
# Fix fatal (PHP8.X) type issue with abs, and amend dol_eval return type I got the following message: `Fatal error: Uncaught TypeError: abs(): Argument #1 ($num) must be of type int|float, string given in D:\mdeweerd\workspace\dolibarr\htdocs\projet\list.php on line 233` I examined the phan report and there was no mention of this because dol_eval was said to return mixed. In order to detect such cases, I amended the dol_eval return type to ensure to find most of the locations where a cast is needed.
JonBendtsen
pushed a commit
that referenced
this pull request
May 6, 2024
… be of type int|float, string given in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/core/tpl/commonfields_add.tpl.php on line 39 (Dolibarr#29595) * fix : Warning: Undefined variable in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/compta/bank/various_payment/list.php on line 370 * backward * update * Fatal error: Uncaught TypeError: abs(): Argument #1 () must be of type int|float, string given in /home/httpd/vhosts/aflac.fr/domains/dol190.aflac.fr/httpdocs/core/tpl/commonfields_add.tpl.php on line 39 * Update commonfields_add.tpl.php fix tab/space * Update commonfields_add.tpl.php fix space after cast
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in the
following fatal error:
GROUP BY fk_facture_fourn
33 DoliDBPgsql::query SQL Error message: ERROR: 42601: syntax error at or near ")"
LINE 10: AND fk_facture_fourn IN ()
^
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output.
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1
($result) must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/purchasesjournal.php(418):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Fixes Dolibarr#32374
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in
fatal errors.
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output:
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1 ($result)
must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/expensereportsjournal.php(264):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Refs Dolibarr#32374 but for the expensereportsjournal page.
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in the
following fatal error:
GROUP BY fk_facture_fourn
33 DoliDBPgsql::query SQL Error message: ERROR: 42601: syntax error at or near ")"
LINE 10: AND fk_facture_fourn IN ()
^
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output.
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1
($result) must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/purchasesjournal.php(418):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Fixes Dolibarr#32374
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in
fatal errors.
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output:
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1 ($result)
must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/expensereportsjournal.php(264):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Refs Dolibarr#32374 but for the expensereportsjournal page.
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in the
following fatal error:
GROUP BY fk_facture_fourn
33 DoliDBPgsql::query SQL Error message: ERROR: 42601: syntax error at or near ")"
LINE 10: AND fk_facture_fourn IN ()
^
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output.
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1
($result) must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/purchasesjournal.php(418):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Fixes Dolibarr#32374
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in
fatal errors.
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output:
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1 ($result)
must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/expensereportsjournal.php(264):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Refs Dolibarr#32374 but for the expensereportsjournal page.
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in the
following fatal error:
GROUP BY fk_facture_fourn
33 DoliDBPgsql::query SQL Error message: ERROR: 42601: syntax error at or near ")"
LINE 10: AND fk_facture_fourn IN ()
^
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output.
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1
($result) must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/purchasesjournal.php(418):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Fixes Dolibarr#32374
eldy
pushed a commit
that referenced
this pull request
Jan 13, 2025
`WHERE xx IN ()` is not allowed in PostgreSQL queries, and result in
fatal errors.
We can check whether we have valid invoices before running the query,
since the query will only check whether the invoices are complete or
not.
It also fixes the following error on the development PHP output:
Fatal error: Uncaught TypeError: pg_num_rows(): Argument #1 ($result)
must be of type PgSql\Result, bool given in
/var/www/html/core/db/pgsql.class.php:654 Stack trace: #0
/var/www/html/core/db/pgsql.class.php(654): pg_num_rows(false) #1
/var/www/html/accountancy/journal/expensereportsjournal.php(264):
DoliDBPgsql->num_rows(false) Dolibarr#2 {main} thrown in
/var/www/html/core/db/pgsql.class.php on line 654
Refs Dolibarr#32374 but for the expensereportsjournal page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
This is a template to help you make good pull requests. You may use Github Markdown syntax to format your issue report.
Please:
FIX|Fix #[issue_number Short description]
[Long description]
CLOSE|Close #[issue_number Short description]
[Long description]
NEW|New [Short description]
[Long description]