Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make startapp log file location configurable by an env var #129

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

brokeh
Copy link
Contributor

@brokeh brokeh commented Feb 22, 2024

So that it is not included in the pushed backups

So that it is not included in the pushed backups
@traktuner
Copy link
Collaborator

Hey,
thanks for the PR!
I'll look into that, but currently, I see that as an added benefit for troubleshooting backup issues (last pushed entry in the log, modification time etc)

@brokeh
Copy link
Contributor Author

brokeh commented Feb 23, 2024

No worries. If there's utility in that behaviour then I can change it to be configurable via an env var then.
Does that sound OK?

@traktuner
Copy link
Collaborator

No worries. If there's utility in that behaviour then I can change it to be configurable via an env var then. Does that sound OK?

We ask people to provide this logfile to see why there may be an issue with the app not starting/installing, etc and therefore we need a defined path to the logfile and that path should not change.
I think it's best to add the file to the exception list in Backblaze so that it's not backed up.
I put it in the root of C: intentionally that it's not dependent on any wine installation or initialization.

@brokeh
Copy link
Contributor Author

brokeh commented Feb 25, 2024

I have no issues with myself (and presumably most others who explicitly set an environment variable) opening a shell into the Docker container and grabbing the log files out from the backend if necessary.

As for excluding it in the Backblaze config, as far as I can tell this is not possible under the current setup. It is only possible to exclude folders and file extensions. Since this is put straight into the root of C:\ it is not possible to exclude it by folder and I do want *.log files as there are some log files in other locations I do want backed up.

@brokeh brokeh changed the title Move startapp log file to Windows temp directory Make startapp log file location configurable by an env var Feb 25, 2024
@traktuner traktuner self-requested a review February 26, 2024 05:08
Copy link
Collaborator

@traktuner traktuner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good solution, thank you!
Please change the readme wording as in the comment.

README.md Outdated Show resolved Hide resolved
@Andrew-Brock
Copy link

Not sure why the CI is filing on this. Doesn't seem like anything related to the change

@traktuner
Copy link
Collaborator

Not sure why the CI is filing on this. Doesn't seem like anything related to the change

yes, that's ecxpected.

@traktuner traktuner merged commit 3d25c59 into JonathanTreffler:main Mar 15, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants