-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor): optimize Dockerfiles, parallel build process #84
Conversation
@JonathanTreffler If you're interested, I'd be happy if you could test those changes. |
Thank you for the PR :) I will review the rest, but before that a small note:
The reason the existing APP_ICON code is commented out is, that I do not have any rights to Backblaze's Logo and I have no idea if I would be allowed to include it in the Docker Image. And I just don't think it is important enough to risk legal trouble :) If you could please take out the APP_ICON from the PR, that would be nice, otherwise I will just merge it as is and remove it on my main branch. Thx :) |
Ah got it - thanks :) |
That would be great, thank you :) I think with all the weird "needing ubuntu 18 for some reason on some devices, nobody knows why" stuff it would be good to stick with ubuntu 20 as the base for the latest image tag for now, but adding the v22 as an extra (non-versioned) tag like ubuntu18 would be great, so people can test it out and give feedback, before we migrate everybody else on latest over to it. |
Sure, I will do that in a separate PR! |
I already added the env and restarted the action, but they are not used here and the docs explain why:
I invited you to be a repository collaborator, so you can develop from a branch instead of a fork if you want :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
I reviewed it so now all prerequisites for a merge should be fullfilled, you should be able to merge it yourself :) |
Changes in this PR:
-) Used new jlesage/baseimage-gui v4 (the image without version tag is not maintained anymore)
-) the Dockerfiles are synchronized now (only difference is the used baseimage)
-) the images now get built in parallel with GitHub Actions*
*) please add a new GitGub actions variable DOCKERHUB_USER to your repo with your username before merging. I wanted to test the build and so I had to use variables instead of a hard coded username 😉