(feat): add ubuntu22 image + build process, update docs #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR ! Except for the requested change (see review) this looks great 👍 |
JonathanTreffler
requested changes
Dec 12, 2023
There was a problem hiding this comment.
The Build Action for the ubuntu 22 action currently fails for this PR, because it tries to push to the tag :pr-85:ubuntu22. Please disabled PR image tags for the ubuntu 22 image, so it behaves like ubuntu18, which just builds the image in PRs, but doesn't try to push it.
traktuner
force-pushed
the
feat/add-ubuntu22-dockerfile
branch
from
216f552 to
6a0e9bc
Compare
|
Also fixes #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in this PR:
-) new :ubuntu22 docker tag with jlesage's ubuntu22 baseimage-gui
-) updated build process
-) readme + changelog updated
The ubuntu20 image will still serve as the default image, as discussed.
The ubuntu18 and ubuntu22 images can only be used with the corresponding tags.