Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TypeScript #35

Closed
Tracked by #28
JoshuaKGoldberg opened this issue Sep 13, 2023 · 1 comment · Fixed by #59
Closed
Tracked by #28

Convert to TypeScript #35

JoshuaKGoldberg opened this issue Sep 13, 2023 · 1 comment · Fixed by #59
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Confirmed with @zetlen this won't interfere with anything. Yay, TypeScript! 🙌
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! area: tooling Managing the repository's maintenance labels Sep 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 13, 2023
This was referenced Sep 13, 2023
Closed
Closed
@JoshuaKGoldberg
Copy link
Owner Author

Marking as blocked on #39. Types are a bit wonky going back to this very old version of ESLint.

@JoshuaKGoldberg JoshuaKGoldberg added status: blocked Waiting for something else to be resolved and removed status: accepting prs Please, send a pull request to resolve this! labels Sep 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! and removed status: blocked Waiting for something else to be resolved labels Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Closed
Closed
JoshuaKGoldberg added a commit that referenced this issue Nov 8, 2023
@JoshuaKGoldberg
feat: converted to TypeScript (#59)
c328633 
Work in progress:

- [x] `npm run tsc` passes
- [x] `npm run test` passes (except for #60)
- [x] Filed docs issue on `jsonc-eslint-parser` to document how to work
effectively with ESTree:
ota-meshi/jsonc-eslint-parser#184

Fixes #35.

Converts source files to TypeScript. In doing so, switches the test
library from Mocha to Vitest so that no transpiling is needed for tests.

~Will wait for feedback on
ota-meshi/eslint-plugin-jsonc#269 before taking
that PR's strategy in here.~ ✅ Brings in
ota-meshi/eslint-plugin-jsonc#271
`RuleListener` type as well.

~Marking as blocked on #60. I'd like that to be resolved before making
any changes that happen to also change tests around.~ ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: converted to TypeScript JoshuaKGoldberg/eslint-plugin-package-json
1 participant
@JoshuaKGoldberg