feat: converted to TypeScript #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Oct 17, 2023
JoshuaKGoldberg
commented
Oct 17, 2023
JoshuaKGoldberg
added
the
status: blocked
2 tasks
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
removed
the
status: blocked
|
Published in |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress:
npm run tscpassesnpm run testpasses (except for Test failures on main with valid-local-dependency.js #60)jsonc-eslint-parserto document how to work effectively with ESTree: Documentation for implementing plugins and TypeScript types? ota-meshi/jsonc-eslint-parser#184Fixes #35.
Converts source files to TypeScript. In doing so, switches the test library from Mocha to Vitest so that no transpiling is needed for tests.
Will wait for feedback on ota-meshi/eslint-plugin-jsonc#269 before taking that PR's strategy in here.✅ Brings in ota-meshi/eslint-plugin-jsonc#271RuleListenertype as well.Marking as blocked on #60. I'd like that to be resolved before making any changes that happen to also change tests around.✅