test: add more test cases for isPackageJson function #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfaith
approved these changes
Jan 21, 2025
|
@all-contributors please add @chouchouji for code |
|
I've put up a pull request to add @chouchouji! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 18 18
Lines 1077 1077
Branches 133 133
=======================================
Hits 1052 1052
Misses 25 25 ☔ View full report in Codecov by Sentry. |
Thanks! |
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Jan 21, 2025
Adds @chouchouji as a contributor for code. This was requested by michaelfaith [in this comment](#761 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
🎉 This is included in version v0.21.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
I had developed some vscode extensions. I will add some json files like
package.nls.jsonorpackage.nls.zh-cn.jsonfor internationalization support. So I add more test cases.