Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary files from package.json files field #791

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Feb 1, 2025

PR Checklist

Overview

Copy link
Collaborator

@michaelfaith michaelfaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up! The broken lock file issue in CI wasn't anything you did in this PR. Renovate bot apparently broke it. I fixed it in #789. So, we'll need to wait to merge this, until that one is merged. But this looks good to me.

@michaelfaith
Copy link
Collaborator

@all-contributors add @chouchouji for maintenance

Copy link
Contributor

@michaelfaith

I've put up a pull request to add @chouchouji! 🎉

@chouchouji
Copy link
Contributor Author

Thanks for taking this up! The broken lock file issue in CI wasn't anything you did in this PR. Renovate bot apparently broke it. I fixed it in #789. So, we'll need to wait to merge this, until that one is merged. But this looks good to me.

Thanks for your reply.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (6c1fa11) to head (61d7feb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #791   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          19       19           
  Lines        1163     1163           
  Branches      139      139           
=======================================
  Hits         1148     1148           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4c72153 into JoshuaKGoldberg:main Feb 1, 2025
12 of 13 checks passed
@chouchouji chouchouji deleted the chore-package branch February 3, 2025 11:50
Copy link

github-actions bot commented Feb 3, 2025

🎉 This is included in version v0.22.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants