Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: extend renovate recommended config #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelfaith
Copy link
Collaborator

@michaelfaith michaelfaith commented Feb 2, 2025

PR Checklist

Overview

This change updates our renovate config to extend the recommended, which will include all monorepo and recommended groups. E.g. grouping vitest updates with @vitest/* updates.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (7b36476) to head (868c950).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #859   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files          19       19           
  Lines        1163     1163           
  Branches      139      139           
=======================================
  Hits         1148     1148           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This change adds grouping config for eslint and vitest package groups.
@michaelfaith michaelfaith changed the title ci: add vitest and eslint renovate groups ci: extend renovate recommended config Feb 2, 2025
@michaelfaith
Copy link
Collaborator Author

@JoshuaKGoldberg I found a better approach for this change. We weren't extending any of the renovate presets. There already is built-in support for the kind of groupings I had created, but you have to extend those presets. They have a recommended config preset, which includes all of those and other nice to have settings. https://docs.renovatebot.com/presets-config/#configrecommended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant