Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency path-to-regexp to v6.3.0 [security] #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 10, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
path-to-regexp 6.2.1 -> 6.3.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-45296

Impact

A bad regular expression is generated any time you have two parameters within a single segment, separated by something that is not a period (.). For example, /:a-:b.

Patches

For users of 0.1, upgrade to 0.1.10. All other users should upgrade to 8.0.0.

These versions add backtrack protection when a custom regex pattern is not provided:

They do not protect against vulnerable user supplied capture groups. Protecting against explicit user patterns is out of scope for old versions and not considered a vulnerability.

Version 7.1.0 can enable strict: true and get an error when the regular expression might be bad.

Version 8.0.0 removes the features that can cause a ReDoS.

Workarounds

All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change /:a-:b to /:a-:b([^-/]+).

If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length. For example, halving the attack string improves performance by 4x faster.

Details

Using /:a-:b will produce the regular expression /^\/([^\/]+?)-([^\/]+?)\/?$/. This can be exploited by a path such as /a${'-a'.repeat(8_000)}/a. OWASP has a good example of why this occurs, but the TL;DR is the /a at the end ensures this route would never match but due to naive backtracking it will still attempt every combination of the :a-:b on the repeated 8,000 -a.

Because JavaScript is single threaded and regex matching runs on the main thread, poor performance will block the event loop and can lead to a DoS. In local benchmarks, exploiting the unsafe regex will result in performance that is over 1000x worse than the safe regex. In a more realistic environment using Express v4 and 10 concurrent connections, this translated to average latency of ~600ms vs 1ms.

References


Release Notes

pillarjs/path-to-regexp (path-to-regexp)

v6.3.0: Fix backtracking in 6.x

Compare Source

Fixed

v6.2.2: Updated README

Compare Source

No API changes. Documentation only release.

Changed


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Sep 10, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21616
    throw new Error(
          ^

Error: Error when performing the request to https://registry.npmjs.org/yarn/latest; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting
    at fetch (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21616:11)
    at async fetchAsJson (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21630:20)
    ... 4 lines matching cause stack trace ...
    at async Object.runMain (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:23110:7) {
  [cause]: TypeError: globalThis.fetch is not a function
      at fetch (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21610:33)
      at async fetchAsJson (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21630:20)
      at async fetchLatestStableVersion (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21557:20)
      at async fetchLatestStableVersion2 (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21679:14)
      at async Engine.getDefaultVersion (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22305:23)
      at async Engine.executePackageManagerRequest (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22403:47)
      at async Object.runMain (/opt/containerbase/tools/corepack/0.31.0/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:23110:7)
}

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-hackernews ❌ Failed (Inspect) Sep 11, 2024 6:19pm

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 8833969

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot changed the title fix(deps): update dependency path-to-regexp to v8 [security] fix(deps): update dependency path-to-regexp to v8 [security] - autoclosed Sep 11, 2024
@renovate renovate bot closed this Sep 11, 2024
@renovate renovate bot deleted the renovate/npm-path-to-regexp-vulnerability branch September 11, 2024 17:32
@renovate renovate bot changed the title fix(deps): update dependency path-to-regexp to v8 [security] - autoclosed fix(deps): update dependency path-to-regexp to v8 [security] Sep 11, 2024
@renovate renovate bot reopened this Sep 11, 2024
@renovate renovate bot restored the renovate/npm-path-to-regexp-vulnerability branch September 11, 2024 18:19
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch from da5e15a to 8833969 Compare September 11, 2024 18:19
@renovate renovate bot enabled auto-merge (rebase) September 12, 2024 17:41
@renovate renovate bot changed the title fix(deps): update dependency path-to-regexp to v8 [security] fix(deps): update dependency path-to-regexp to v6.3.0 [security] Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants