added migration scripts & utils.sh file #2861
Conversation
ignazio-bovo
requested review from
mnaamani
and removed request for
mnaamani
ignazio-bovo
force-pushed
the
giza_it_migration_scripts
branch
from
990944a to
545c346
Compare
ignazio-bovo
force-pushed
the
giza_it_migration_scripts
branch
from
fcd7a52 to
1bb1e20
Compare
|
I encountered a problem on the @joystream/cli side, @Lezek123 has been kind enough to start fixing it. |
…o-bovo/joystream into giza_it_migration_scripts
ignazio-bovo
force-pushed
the
giza_it_migration_scripts
branch
from
caa2df5 to
55d1efe
Compare
| .forEach(([key, value]) => (chainSpec.genesis.raw.top[key] = value)); | ||
|
|
||
| // Delete System.LastRuntimeUpgrade to ensure that the on_runtime_upgrade event is triggered | ||
| delete chainSpec.genesis.raw.top['0x26aa394eea5630e07c48ae0c9558cef7f9cce9c888469bb1a0dceaa129672ef8']; |
There was a problem hiding this comment.
It would be better to show how these raw values are derived so this script can be generalized if we use it against a different chain.
There was a problem hiding this comment.
The raw values are derived from the pallet name + storage element (+ eventual key in the map). Deriving the value I believe doesn't prevent the script from breaking in case of a different chain (since it depends on the chain pallets configuration), but it makes it easier to fix...
There was a problem hiding this comment.
Almost there, made a few last suggestions.
In test/network-tests/ working directory:
There are a few linter fixes to do in the typescript code.
run yarn checks to check them (or you might see them in your editor with eslint plugin enabled)
run yarn format to fix formatting.
Refers to #2828