Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs and convert jldoctest to @repl blocks #607

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk commented Jan 5, 2024

Doctest is very fragile.
Using @repl, we can update documentation automatically.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d319168) 83.38% compared to head (e294104) 83.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          12       12           
  Lines        2378     2378           
=======================================
  Hits         1983     1983           
  Misses        395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviatesk
Copy link
Member Author

aviatesk commented Jan 5, 2024

It looks like https://github.com/JuliaDebug/JuliaInterpreter.jl/actions/runs/7418164310/job/20185719270?pr=607 saying our DOCUMENTER_KEY isn't setup correctly? The doc deployment is actually failing on master too.

Doctest is very fragile.
Using `@repl`, we can update documentation automatically.
@aviatesk aviatesk merged commit 0089e4b into master Jan 6, 2024
5 of 14 checks passed
@aviatesk aviatesk deleted the avi/docs branch January 6, 2024 02:19
@timholy
Copy link
Member

timholy commented Jan 7, 2024

I updated DOCUMENTER_KEY earlier today, should be OK now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants