Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also unset repo in the packages make.jl #222

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Aug 8, 2024

After #216, we're setting the remotes keyword to nothing. But if the user's make.jl sets the repo, then we'll fail to generate the documentation with:

ERROR: LoadError: 
ArgumentError: When `remotes` is set to `nothing`, `repo` must not be set.

So this also enforces the repo = "" default, to ensure that the documentation builds don't fail.

@mortenpi mortenpi requested a review from vdayanand August 8, 2024 05:52
@mortenpi mortenpi merged commit c75e6ee into master Aug 9, 2024
2 checks passed
@mortenpi mortenpi deleted the mp/fix-repo-kwarg branch August 9, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants