-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Makie error in interactive_orbitdiagram #239
Conversation
Fixed Makie error in `interactive_orbitdiagram`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jonathanfischer97 . The reason there are no tests here is because in the past DynamicalSystems.jl had no source code. It simple re-exported all other packages of the library. However, recently I decided to move here all GUI related code. However, that code never had tests because I didn't know exactly what or how to test plotting code.
Adding tests is of course an important and great improvement, so thank you for doing that. I left some comments to improve the tests.
If by any chance you have some spare time, adding the same test fig = gui_function(); @test fig isa Makie.figure()
to all GUI applications would be a great addition to the library.
Furthermore, can you please increase patch version number in Project.toml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reason to leave commented code in
No problem, happy to help! I'll add more tests as I explore more of the visualization methods! |
I fixed the
Makie.Layout
error I raised in #237 by removing that qualifier from thedeactivate_interaction!
call.Other changes that can be ommitted upon review
display(figure)
calls because they seemed unnecessary and aren't shared by the other interactive plotting scripts.Vector{Point2f}
in the firstminimal_normalized_od
method because the length is known at compile time (the other method has conditional push so left it as is)Test.jl
based CI for a reason or was just never implemented. The test fails with an error with the prior code but passes now.