Reverse with multiple dimensions

[RainerHeintzmann]

This code allows reverse to be used also in the new signature dims=(1,3) or dims=: as common starting with Julia 1.6.

If the tests run through I do get a Windows Blue Screen in my system, but this issue also existed in the version this fork was generated from.

[maleadt]

Thanks! Some minor changes.

[RainerHeintzmann]

.... a test is failing. I am checking this.

[RainerHeintzmann]

should be OK now. Test was running fine.

[maleadt]

Unintended changes?

[maleadt]

Pushed some small fixes, but this should be good to go, thanks! Let's wait for CI and merge this.

FWIW, I had some trouble rebasing this. It's better not to merge branches on a PR, especially external master branches, but always rebase on top of the destination branch.

[RainerHeintzmann]

I guess this was caused by me clicking on "Synchronize" in Github, which pulled the current version from your master branch and merged it with my version? Not really sure how to do a rebase though...
For starting to work on the FFT problem, should I do a new fork or split my fork into a new branch?

[maleadt]

For starting to work on the FFT problem, should I do a new fork or split my fork into a new branch?

It's recommended to use feature branches on your fork, otherwise multiple PRs get tricky.

I guess this was caused by me clicking on "Synchronize" in Github, which pulled the current version from your master branch and merged it with my version? Not really sure how to do a rebase though...

Yeah, I'm not sure what happened either 🙂 Normally the Update button does have a Rebase option in the dropdown, but I generally do those operations locally using git (git fetch origin && git rebase origin/master).