get closer to working docs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs were not building on Documenter 1 due to the repo link, but this doesn't seem needed, since the GitHub link in the rendered docs points to the right location. This removes the accidentally committed docs/build, and updates .gitignore to ensure that won't happen again. Updated the "Manual test" code and made sure it is working.
|
This image from the docs still seems to give issues. Perhaps we can just load it from here and remove it from the repo: 
|
|
Just noticed that getting this all working again is more that I have time for right now. I see there is #13 open for it as well. Shall we just get this in, since it does get us closer? |
|
Im not sure if Leaflet even works anymore, as WebIO.jl is kind of abandoned. |
|
Yeah I tried this manual test from runtests and that seemed to work well. |
rafaqz
approved these changes
Oct 16, 2023
|
Ugh damn the docs were actually broken, maybe In misunderstood your "shall we just get this in" comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs were not building on Documenter 1 due to the repo link, but this doesn't seem needed, since the GitHub link in the rendered docs points to the right location.
This removes the accidentally committed docs/build, and updates .gitignore to ensure that won't happen again.
Updated the "Manual test" code and made sure it is working.