Update around broadcasting #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How’s this going? |
|
I'm sorry that I did not have time for OSS in recent days. I will try updating this PR tomorrow! 💪 |
hyrodium
force-pushed
the
fix/revert_arithmetic_and_broadcasting
branch
from
da9efcb to
aa47042
Compare
|
I think the dictionary order with julia> Point(1,3) < Point(0,4)
false
julia> Point(1,3) < Point(2,1)
trueIf you agree with that, I will fix this in another PR! x-ref: https://github.com/JuliaGraphics/Luxor.jl/blob/master/test/point-arithmetic.jl#L46-L48 |
|
Sure! Just let me know when you’ve finished all the changes you feel are important - then I can go ahead and make the 4.0 release. |
|
This is ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the late PR.
This PR is related to this comment: #295 (comment).
Changes in this PR:
Point(1,2) .+ 3is now invalid.Point(1,2) + Point(3,3)instead.CHANGELOG.mdis also updated.[Point(1,2), Point(4,1)] .+ Point(3,4)is now valid.Refin code.Refinbetween.(Ref(pt1), Ref(pt2), range).betweenmethods introduced in 90d006b.v3.8.0,[Point(1,2), Point(4,1)] .+ Point(3,4)was valid too.[Point(1,2), Point(4,1)] .+ Point(3,4)turned invalid, and we needed to write[Point(1,2), Point(4,1)] .+ Ref(Point(3,4))instead.[Point(1,2), Point(4,1)] + Point(3,4)is now valid.[Point(1,2), Point(4,1)] .+ Ref(Point(3,4))is also still valid.