Skip to content

Commit

Permalink
remove the delete! with a comment
Browse files Browse the repository at this point in the history
  • Loading branch information
IanButterworth committed Jan 10, 2025
1 parent b22bef4 commit 0646715
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/Operations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,9 @@ function resolve_versions!(env::EnvCache, registries::Vector{Registry.RegistryIn
new_v = vers_fix[uuid]
compat_map[uuid][old_v] = compat_map[uuid][new_v]
vers_fix[uuid] = old_v
new_v != old_v && delete!(compat_map[uuid], new_v)
# Note that we don't delete!(compat_map[uuid], old_v) because we want to keep the compat info around
# in case there's JLL version confusion between the sysimage pkgorigins version and manifest
# but that issue hasn't been fully specified, so keep it to be cautious
end
end
vers = vers_fix
Expand Down

0 comments on commit 0646715

Please sign in to comment.