Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/src/environments.md: update Julia version #3715

Merged
merged 1 commit into from
Dec 18, 2023
Merged

docs/src/environments.md: update Julia version #3715

merged 1 commit into from
Dec 18, 2023

Conversation

jcsahnwaldt
Copy link
Contributor

@jcsahnwaldt jcsahnwaldt commented Nov 30, 2023

1.8 -> 1.9, 1.8.2 -> 1.9.4 (current version)

1.8 -> 1.9, 1.8.2 -> 1.9.4 (current version)
@jcsahnwaldt jcsahnwaldt changed the title environments.md: update Julia version docs/src/environments.md: update Julia version Nov 30, 2023
@jcsahnwaldt
Copy link
Contributor Author

jcsahnwaldt commented Nov 30, 2023

I guess the current Julia version occurs in other files as well. It might be nice if it could be automatically updated or inserted by the build process. Is there already a build step that replaces variables in MarkDown or other text files?

@IanButterworth
Copy link
Member

The julia version on master is actually 1.11
There's unlikely to be another 1.9 release, but we could backport another PR onto the release-1.10 branch to update 1.10 though

@jcsahnwaldt
Copy link
Contributor Author

I could update the PR and set the version to 1.11 instead. But a better long-term solution would be to replace the hard-coded version by a variable that gets replaced during the build process.

I had a quick look at how the docs are built. Maybe an @eval-block would work? Is the target version available as a Julia variable during the build? If not, can we add it somewhere, e.g. in docs/make.jl? Then I'd change the PR and add something like @eval SomeModule.targetVersion() instead of the hard-coded version strings.

@KristofferC KristofferC merged commit a6531d4 into JuliaLang:master Dec 18, 2023
11 of 13 checks passed
KristofferC pushed a commit that referenced this pull request May 9, 2024
1.8 -> 1.9, 1.8.2 -> 1.9.4 (current version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants