-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pidlock source and artifact installation #4168
Pidlock source and artifact installation #4168
Conversation
274d247
to
3db4eb8
Compare
bd55f9d
to
7c0087b
Compare
4f4f6a8
to
a7acf16
Compare
This comment was marked as resolved.
This comment was marked as resolved.
adada98
to
f03a16b
Compare
f03a16b
to
3bb68e5
Compare
aa0f530
to
97c3813
Compare
97c3813
to
4c58479
Compare
ef18a94
to
6fb66bd
Compare
b4b16f8
to
d838b3d
Compare
These tests add between 1m40s and 4m (linux git registry). I'm thinking of merging this and trying out in a Pkg bump PR to see the impact on Julia CI. Adjusting as necessary. |
I saw the same hang locally on macOS when testing two concurrent processes, so I don't think the test failures are just CI peculiarities.
Update: Fixed. I had a design flaw not pushing the expected number of elements to a channel. |
3b0e9e3
to
09244b4
Compare
f9b320c
to
95a3f04
Compare
ff78e29
to
8f2fb06
Compare
8f2fb06
to
a8f43cc
Compare
@staticfloat this should be good to go now |
I want to test this on Julia CI so I'm going to dismiss these requested changes (which have been addressed).
Post merge review very much welcome!
Fixes #3495
Fixes #4174
Also fixes registry installation which wasn't checking after acquiring the pidlock which registries still needed installing.
Makes progress on #2219
But only if all concurrent julia process installations have this fix.. I'm not sure there's a way to protect against older versions..
Source:
mv
from temp dir to final path by checkingtree_hash
before and after and deleting the destination if bad.Artifacts:
Registries:
Screen.Recording.2025-02-25.at.5.20.45.PM.mov
Todo: