Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type of jl_lineno #16131

Merged
merged 1 commit into from
May 1, 2016
Merged

Correct type of jl_lineno #16131

merged 1 commit into from
May 1, 2016

Conversation

yuyichao
Copy link
Contributor

It was my fault in #11311 = = .....

@yuyichao yuyichao closed this May 1, 2016
@yuyichao yuyichao deleted the yyc/depwarn_line branch May 1, 2016 01:29
@tkelman
Copy link
Contributor

tkelman commented May 1, 2016

did someone else get this? backport needed or not?

@yuyichao
Copy link
Contributor Author

yuyichao commented May 1, 2016

The issue is present in the code on 0.4. Is this not enough reason for backport?

@tkelman
Copy link
Contributor

tkelman commented May 1, 2016

did you mean to merge instead of close? is this testable? I dislike backporting things that never go to master, without a good reason

@yuyichao yuyichao restored the yyc/depwarn_line branch May 1, 2016 13:01
@yuyichao yuyichao reopened this May 1, 2016
@yuyichao yuyichao merged commit 72f3970 into master May 1, 2016
@yuyichao yuyichao deleted the yyc/depwarn_line branch May 1, 2016 13:01
@yuyichao
Copy link
Contributor Author

yuyichao commented May 1, 2016

did you mean to merge instead of close?

Yes. = =....

is this testable?

Not easily?

tkelman pushed a commit that referenced this pull request Jun 17, 2016
(cherry picked from commit 26fe0df)
ref #16131
yuyichao added a commit that referenced this pull request Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants