Change JuliaSyntaxHighlighting UUID #56852
Conversation
Unfortunately during development of the backported version of this stdlib, to avoid potential sysimage issues the UUID was temporarilly changed and I forgot to change it back. This mistake lead to the backport/compat verison of the package having a different UUID from the in-tree stdlib. Beyond this being an embarassing mistake, it's also a pain because it means that we now have incorrect/invalid manifests. A small mercy is that 1.12 hasn't been released yet, so the discrepancy currently only affects people using development Julia versions. Changing the UUID here will require these people to regenerate their manifests, but this seems like the lesser of too evils.
|
@tecosaur Any Update? |
|
We should, and I'll do exactly that — I've just been travelling recently. |
This comment was marked as outdated.
This comment was marked as outdated.
|
As mentioned above, it turns out this is good to go. |
There was a problem hiding this comment.
LGTM
A quick recap:
We have registered the wrong UUID (ac6e5ff7-) for JuliaSyntaxHighlighting.jl in General.
name = "JuliaSyntaxHighlighting"
uuid = "ac6e5ff7-fb65-4e79-a425-ec3bc9c03011"
repo = "https://github.com/JuliaLang/JuliaSyntaxHighlighting.jl.git"To minimize the impact, we chose to make the UUID registered in General the correct one.
So we need to update the UUID in Project.toml of JuliaLang/JuliaSyntaxHighlighting.jl.
dc6e5ff7-* => ac6e5ff7-*
name = "JuliaSyntaxHighlighting"
uuid = "dc6e5ff7-fb65-4e79-a425-ec3bc9c03011"I'll update this branch to make sure everything works on the latest master branch.
|
I'm going to merge this pr in about a day or two. Add the |
|
I think we need to get this PR in before 1.12 is branched. It would be good if someone else could take a look at this and make sure it looks correct/won't break anything. @KristofferC Could you review this? |
That is very hard to say, swapping out a UUID like this can be quite traumatic for code loading and Pkg. But worst case you get some weird error and have to regenerate your manifest and the current situation is so bad we have to do this nonetheless. |
DilumAluthge
removed
the
merge me
|
Is there an easy way to regenerate the current manifest file from within julia? |
|
@felixcremer not that I'm aware of. You have two options:
|
TLDR; I made a silly mistake a while back, and this seems like the least bad option.
Unfortunately during development of the backported version of this stdlib, to avoid potential sysimage issues the UUID was temporarilly changed and I forgot to change it back.
This mistake lead to the backport/compat verison of the package having a different UUID from the in-tree stdlib. Beyond this being an embarassing mistake, it's also a pain because it means that we now have incorrect/invalid manifests.
A small mercy is that 1.12 hasn't been released yet, so the discrepancy currently only affects people using development Julia versions. Changing the UUID here will require these people to regenerate their manifests, but this seems like the lesser of two evils.
Appologies for the hassle all.