[release-1.11] Avoid dropping call edges in presence of identical invoke edges
#57077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intermediate data structure here (used for edge de-duplication) was accidentally recording `invoke` edges as if they were `call` edges. This bug is _very_ frequently benign, but if there are identical call and invoke edges in the edge list and the invoke edge is scanned first, the call edge will be unsoundly dropped, leading to invalidation (JuliaLang#265) bugs.
topolarity
added
backport 1.10
maleadt
approved these changes
Jan 17, 2025
|
Can we get a test for this both here and on master? |
oscardssmith
added
bugfix
topolarity
removed
backport 1.10
topolarity
added
compiler:precompilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intermediate data structure here (used for edge de-duplication) was accidentally recording
invokeedges as if they werecalledges.That bug is very frequently benign, but if there are identical call and invoke edges in the edge list and the invoke edge is scanned first, the call edge will be unsoundly dropped, leading to invalidation (#265) bugs.
Already fixed on master (by happy accident) as part of #54894