Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move jl_task_t to julia_threads.h #57117

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

fingolfin
Copy link
Member

This is a subset of PR #56477 by @vtjnash . I hope that it will be easier to get this merged first, as it just moves things around, afterwards we can update #56477 and it will be considerably smaller, and will thus hopefully break less often (and in less bad ways) over time. (I can perform the required update of that PR, too).

See also PR #57116 which contains another independent part of that PR.

@fingolfin fingolfin requested a review from vtjnash January 21, 2025 14:26
@fingolfin fingolfin changed the title Move jl_task_t to julia_threads.h Move jl_task_t to julia_threads.h Jan 21, 2025
Copy link
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will rebase to re-run CI -- a large number of the tests seem to have failed due to unrelated reasons.

@d-netto d-netto added the merge me PR is reviewed. Merge when all tests are passing label Jan 21, 2025
@fingolfin
Copy link
Member Author

Again CI failures, but they look unrelated?

2025-01-21 22:44:12 INFO   Searching for artifacts: "julia-50e915bb18-musl-x86_64.tar.gz"
fatal: failed to download artifacts: No artifacts found for downloading

@vtjnash vtjnash merged commit 61e8f1d into JuliaLang:master Jan 22, 2025
5 of 8 checks passed
@fingolfin fingolfin deleted the mh/move-jl_task_t branch January 22, 2025 15:06
@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Jan 23, 2025
xal-0 pushed a commit to xal-0/julia that referenced this pull request Jan 24, 2025
This is a subset of PR JuliaLang#56477 . I hope that it will be easier to get
this merged first, as it just moves things around, afterwards we can
update JuliaLang#56477 and it will be considerably smaller, and will thus
hopefully break less often (and in less bad ways) over time. (I can
perform the required update of that PR, too).

See also PR JuliaLang#57116 which contains another independent part of that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants