Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Base.bitcast(ty, v) to all packed isbits types. #57227

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Extend Base.bitcast(ty, v) to all packed isbits types. #57227

wants to merge 1 commit into from
+19 −4

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Jan 31, 2025

Previously, Base.bitcast(ty, v) only supported primitive types. This commit extends it to support any packed isbits type.

@NHDaly
Extend Base.bitcast(ty, v) to all packed isbits types.
de41c51 
Previously, `Base.bitcast(ty, v)` only supported primitive types.
This commit extends it to support any packed isbits type.
@NHDaly NHDaly mentioned this pull request Jan 31, 2025
Open
@Seelengrab
Copy link
Contributor

Why does this need to be done in bitcast? It seems to me to be quite dangerous to allow more cases of arbitrary bypassing of constructors, just because the bitsizes of the two types happen to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NHDaly @Seelengrab