Update embedding.rst #8003
Closed
Update embedding.rst #8003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the compiler include (-I) directories to point to the correct location
|
see #6327 for an alternative fix. While your solution is correct when compiling against a source build, an installed version really should have all the header in a single directory. |
|
Ah sorry I meant #6455 |
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3 to
1a4c02f
Compare
|
I agree that we should have all the headers in one directory. We should make it possible to embed with just one include file, even if embedding out of the source tree. |
|
The missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the compiler include (-I) directories to point to the correct location