Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Aqua.jl-based checks #186

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Introduce Aqua.jl-based checks #186

merged 4 commits into from
Apr 16, 2024

Conversation

mateuszbaran
Copy link
Member

@mateuszbaran mateuszbaran added preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready labels Apr 13, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (b0c9f51) to head (6a26c0e).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          27       27           
  Lines        3156     3156           
=======================================
  Hits         3155     3155           
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kellertuer
kellertuer approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe not worth a new version, o maybe it is ok if this resides on master until a next good feature comes along?

@kellertuer
Copy link
Member

Ah one minor thing, you could add the Aqua badge to the badges in the Readme.

@mateuszbaran
Copy link
Member Author

OK, then I won't tag a new version for now. There are no new features or bugfixes here after all.

BTW, I've already added the badge to Readme.

@mateuszbaran mateuszbaran merged commit 830c5a1 into master Apr 16, 2024
15 checks passed
@kellertuer kellertuer deleted the mbaran/aqua branch May 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellertuer kellertuer kellertuer approved these changes

Assignees
No one assigned
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszbaran @kellertuer