-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚Switch to using DocumenterInterLinks for ManifoldsBase.jl #366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 73 73
Lines 6822 6822
=======================================
Hits 6804 6804
Misses 18 18 ☔ View full report in Codecov by Sentry. |
This should be finished so far. I think since this is just a technical update, it should maybe not get its own release but be part of the next one. |
LGTM. Do you prefer do merge this one first or the sectional curvature one? |
Co-authored-by: Mateusz Baran <[email protected]>
Yes, I think merging this one first has two advantages
|
This is still a bit WIP, since we have to
.io/ManifoldsBase.jl/
in the docs and check whether to replace that with an interlink (probably in all cases besides the Readme.mdBut in general it seems to work really nice and smoothly, following the ideas mentioned at http://juliadocs.org/DocumenterInterLinks.jl/stable/syntax/