Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework the Tracks object; close #278, close #277 #280

Merged
merged 17 commits into from
Mar 19, 2022

Conversation

jverzani
Copy link
Member

Following #278 this reworks the Tracks structure:

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #280 (e3d7e29) into master (feb9bee) will increase coverage by 0.12%.
The diff coverage is 56.06%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   84.51%   84.64%   +0.12%     
==========================================
  Files          12       12              
  Lines        2086     2084       -2     
==========================================
+ Hits         1763     1764       +1     
+ Misses        323      320       -3     
Impacted Files Coverage Δ
src/find_zeros.jl 95.90% <ø> (ø)
src/bracketing.jl 90.41% <35.29%> (+1.19%) ⬆️
src/find_zero.jl 70.12% <53.84%> (-1.55%) ⬇️
src/order0.jl 89.00% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb9bee...e3d7e29. Read the comment docs.

@KronosTheLate
Copy link
Contributor

I want to mention that NLSolve.jl uses the three kwargs show_trace::Bool, store_trace::Bool, and extended_trace::Bool. Trace feels very natural in my mind, and is in fact the word that comes to mind when I think about this. Consistency within the ecosystem is something that I find extremely valuable.

@jverzani
Copy link
Member Author

Let's make the name a separate issue, as it will be breaking. This PR should improve the structure now known as Tracks, as it has the benefit of working better with the hybrid Order0 method and other tweaks. Once I merge this PR, would you port your documentation improvements, with any adjustment? (I could also copy and paste them in to this PR if you want, just let me know).

@KronosTheLate
Copy link
Contributor

Let's make the name a separate issue, as it will be breaking. This PR should improve the structure now known as Tracks, as it has the benefit of working better with the hybrid Order0 method and other tweaks. Once I merge this PR, would you port your documentation improvements, with any adjustment? (I could also copy and paste them in to this PR if you want, just let me know).

Good idea keeping it separate. I see no problem in you copying in any changes I made in my PR - remember to include the new section in the docs ^_^

@jverzani jverzani merged commit 0ad4fc2 into JuliaMath:master Mar 19, 2022
@jverzani jverzani deleted the issue_278 branch March 19, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracker works poorly for bracketing methods
2 participants