Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing extended trace failure for Adam and AdaMax and generalising alpha parameter to accept callable object (scheduler) #1115

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixing extended trace failure for Adam and AdaMax and generalising alpha parameter to accept callable object (scheduler) #1115

wants to merge 8 commits into from

Commits on Oct 30, 2024

  1. adding alpha to state and generalizing alpha to accept a function (sc… 

    …heduler)
    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    89efb0f View commit details
    Browse the repository at this point in the history

  2. removing unused variables

    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ed269f0 View commit details
    Browse the repository at this point in the history

  3. adding alpha to AdaMax state and generalizing alpha to accept a funct… 

    …ion (scheduler)
    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5e5de78 View commit details
    Browse the repository at this point in the history

  4. updating the docstring for Adam to add description of scheduled alpha… 

    … constructors
    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3b752fd View commit details
    Browse the repository at this point in the history

  5. updating the docstring for AdaMax to add description of scheduled alp… 

    …ha constructors
    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f55fa3a View commit details
    Browse the repository at this point in the history

  6. adding tests for scheduled Adam and AdaMax, which covers testing exte… 

    …nded_trace=true case
    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8a8aa2d View commit details
    Browse the repository at this point in the history

  7. adding default constant alpha case tests for extended_trace=true for … 

    …Adam and AdaMax
    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b848abf View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into kn/adam-gen-fix

    @kishore-nori
    kishore-nori committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9d2a5f2 View commit details
    Browse the repository at this point in the history