-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ordinations (MDS and PCA) #230
Conversation
Maybe don't merge until we get an answer about the aspect ratio thing. Also might want to regress that previous one, since it might break things if folks don't have MultivariateStats.jl master. I can put the MDS (and any other ordinations you think I should try) here. |
Good point - this is awesome! |
I've reverted the MDS PR, so if you rebase this and keep that code when resolving the conflict it should work cleanly I guess? |
Link to discourse post about aspect ratio. |
I'm unclear if I should stop using |
There's been some discussion on rows vs columns for input data in MultivariateStats - is this related to that? |
It's related, but it's not only that. At the moment, one can get the scaled axes by using |
I've reached the point where I'm happy to accept anything you find best :-) |
Lol, K. I think it's going to require MultivariateStats exposing eigenvectors of the PCA. Since we need to wait for a release before this gets merged anyway, I'll just wait until then before attempting to fix. Will let you know. |
Bump :) |
@asinghvi17 I think you need to bump MultivariateStats - this depends on a PR that's merged in master over there but doesn't have a release yet. |
The change to MDS has finally been merged, so this can move forward. Unfortunately, I'm stuck with
Unfortunately, PCA isn't working so well:
I think this is because the eigenvectors (acquired using I'm wondering if this PR should go back to being just about MDS, and leave PCA for someone a bit more knowledgable about linear algebra... |
I think this is ready to go as well. I removed the PCA recipe, but will refactor once JuliaStats/MultivariateStats.jl#109 is worked out. |
Thanks @kescobo . And I see we went with aspect_ratio = 1 in the end 😂 |
Yeah, you bullied me into it 😛 |
EDIT: Wait to merge for a tagged version of MultivariateStats that includes JuliaStats/MultivariateStats.jl#85
Unfortunately, the interface is not super generic across ordinations, but here at least is PCA:
This and PCoA are the only ones I'm familiar with. I could try some others, but I'm not confident I'd do the correctly.