-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the trace-compile option to the julia initialization #530
Open
rdyro
wants to merge
8
commits into
JuliaPy:master
Choose a base branch
from
rdyro:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
afcb72a
adding the trace-compile option to the julia initialization
rdyro da65c1d
fixing supported options documentation
rdyro 7e01547
adding a test to the new trace_compile option
rdyro fdd5fd2
hopefully fixing the trace compile file creating via full path specif…
rdyro 4491f77
trace compile path appears to be placed weirdly on windows, skipping …
rdyro f0981f2
adding expected precompile call test
rdyro 1c3d83e
fixing formatting error
rdyro 7bd924f
another fix to formatting
rdyro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import os | ||
from pathlib import Path | ||
from subprocess import check_call | ||
|
||
import pytest | ||
|
||
from .test_compatible_exe import runcode | ||
from .utils import skip_in_windows | ||
|
||
|
||
@skip_in_windows | ||
def test_trace_file_created(tmpdir): | ||
trace_compile_path = Path(tmpdir) / "trace_compile.jl" | ||
runcode( | ||
""" | ||
from julia.api import Julia | ||
jl = Julia(trace_compile="{}") | ||
|
||
from julia import Main | ||
Main.sin(2.0) | ||
""".format( | ||
str(trace_compile_path) | ||
) | ||
) | ||
assert (trace_compile_path).exists() | ||
assert len(trace_compile_path.read_text().strip()) > 0 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some compilation string that you know should be printed to this file? If so, could you test that it actually shows up there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a great idea! I added a check for the precompilation directive of the
sin
function we invoke to test precompilation.