-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve _invalid_sequential_version
msg.
#533
Merged
ericphanson
merged 6 commits into
JuliaRegistries:master
from
shayandavoodii:seq-ver-msg
Dec 8, 2023
Merged
Improve _invalid_sequential_version
msg.
#533
ericphanson
merged 6 commits into
JuliaRegistries:master
from
shayandavoodii:seq-ver-msg
Dec 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayandavoodii
changed the title
Improved
Improve Nov 22, 2023
_invalid_sequential_version
msg._invalid_sequential_version
msg.
ericphanson
reviewed
Nov 23, 2023
ericphanson
reviewed
Nov 23, 2023
ericphanson
previously approved these changes
Nov 24, 2023
ericphanson
reviewed
Nov 24, 2023
bors merge |
Thank you so much for considering my proposal. |
bors ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created due to this discussion. When a version skipping happens, the RegistryCI shows the following message:
In my opinion, this message gives the impression that version skipping is strictly prohibited. It seems to say that you should not do this, but if you did, you need to provide a convincing explanation for why you skipped some versions. Otherwise, the PR will not be merged. However, I can infer that the reason for this check is to prevent any mistakes rather than to ban version skipping. As Mr. Giordano stated:
However, the message I mentioned earlier could imply that developers who deliberately skipped some versions are doing something wrong or problematic, while the main purpose of this check is to prevent mistakes. Therefore, I opened this PR to improve the message. I appreciate your feedback and any suggestions you might have.