Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve _invalid_sequential_version msg. #533

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Improve _invalid_sequential_version msg. #533

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8bdc566
Improved `_invalid_sequential_version` msg.
shayandavoodii Nov 22, 2023
3f6f103
replace 'recommended' by 'required'.
shayandavoodii Nov 22, 2023
d387bf4
shayandavoodii Nov 23, 2023
a7e4a12
Update src/AutoMerge/guidelines.jl
ericphanson Nov 23, 2023
58e9e49
Update src/AutoMerge/guidelines.jl
ericphanson Nov 24, 2023
43b6fc1
Merge branch 'master' into seq-ver-msg
ericphanson Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AutoMerge/guidelines.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ function meets_repo_url_requirement(pkg::String; registry_head::String)
end

function _invalid_sequential_version(reason::AbstractString)
return false, "Does not meet sequential version number guideline: $reason", :invalid
return false, "Does not meet sequential version number guideline: $(reason). If this was intentional, please leave a comment saying so. Otherwise please correct the version number in your package and re-trigger registration.", :invalid
end

function _valid_change(old_version::VersionNumber, new_version::VersionNumber)
Expand Down
Loading