TikzPictures.jl requirement #110

d-monnet · 2023-11-03T16:23:31Z

Makes TikzPictures.jl a requirement for using export_performance_profile_tikz()

…ile_tikz

d-monnet · 2023-11-03T16:30:56Z

For some reason it looks like TikzPictures.jl functions cannot be called when calling export_performance_profile_tikz() even if the package has been loaded...

using BenchmarkProfiles
export_performance_profile_tikz()

returns

ERROR: Please load TikzPictures.jl package to access this function.

as expected, but

using TikzPictures
export_performance_profile_tikz(rand(25,3),"figure")

returns

ERROR: UndefVarError: TIKZ not defined

while TIKZ is exported by TikzPictures.jl.

This also causes the tests to crash.

github-actions · 2023-11-03T16:41:43Z

Package name	latest	stable
SolverBenchmark.jl

d-monnet · 2023-11-03T16:43:42Z

For some reason it looks like TikzPictures.jl functions cannot be called when calling export_performance_profile_tikz() even if the package has been loaded...
using BenchmarkProfiles
export_performance_profile_tikz()
returns
ERROR: Please load TikzPictures.jl package to access this function.
as expected, but
using TikzPictures
export_performance_profile_tikz(rand(25,3),"figure")
returns
ERROR: UndefVarError: TIKZ not defined
while TIKZ is exported by TikzPictures.jl.

This also causes the tests to crash.

Just fixed the issue, using TikzPictures was missing in tikz_export.jl.

github-actions · 2023-11-03T17:00:15Z

Package name	latest	stable
SolverBenchmark.jl

tmigot

Thanks for the PR! It looks essentially good, just one comment

Project.toml

remove unecessary pkg specification in tests

d-monnet · 2023-11-06T15:27:43Z

Thanks for the PR! It looks essentially good, just one comment

Thanks for noticing !

codecov · 2023-11-06T15:32:07Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e639a63) 96.39% compared to head (f99bd6a) 96.09%.
Report is 2 commits behind head on main.

Files	Patch %	Lines
src/BenchmarkProfiles.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   96.39%   96.09%   -0.31%     
==========================================
  Files           5        5              
  Lines         305      307       +2     
==========================================
+ Hits          294      295       +1     
- Misses         11       12       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-11-06T15:38:02Z

Package name	latest	stable
SolverBenchmark.jl

tmigot

Just trying to fix the tests

src/BenchmarkProfiles.jl

github-actions · 2023-11-07T11:07:06Z

Package name	latest	stable
SolverBenchmark.jl

tmigot · 2023-11-07T15:42:29Z

Hi @d-monnet the test fails here. Could you follow the example of ADNLPModels.jl for this?
I think the solution is to remove the test and extra section from the Project.toml and add a Project.toml in the test folder https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/main/test/Project.toml (so we also add version to packages used in tests)

…arkProfiles.jl into tikz-dep-require

github-actions · 2023-11-07T19:58:41Z

Package name	latest	stable
SolverBenchmark.jl

d-monnet · 2023-11-07T20:08:30Z

Hi @d-monnet the test fails here. Could you follow the example of ADNLPModels.jl for this? I think the solution is to remove the test and extra section from the Project.toml and add a Project.toml in the test folder https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/blob/main/test/Project.toml (so we also add version to packages used in tests)

It doesn't seem to solve the problem...

github-actions · 2023-11-13T22:34:58Z

Package name	latest	stable
SolverBenchmark.jl

github-actions · 2023-11-17T17:47:44Z

Package name	latest	stable
SolverBenchmark.jl

github-actions · 2023-11-17T17:53:53Z

Package name	latest	stable
SolverBenchmark.jl

tmigot

Hey @d-monnet ! It finally works :). When you use Require you no longer do the using

tmigot · 2023-11-17T17:54:19Z

test/Project.toml

+UnicodePlots = "b8865327-cd53-5732-bb35-84acbb429228"
+
+[compat]
+LaTeXStrings = "^1.3"


Could you add the missing entries here?

Thanks @tmigot ! Sure, on it ! I was wondering what default versions are used for the [extra] entry of the main Project.toml, since the tests were working with whatever these versions were before I added the requirement feature ?

https://github.com/JuliaSmoothOptimizers/BenchmarkProfiles.jl/actions/runs/6907307413/job/18794184718?pr=110#step:6:46

It will take the most up-to-date version

Should compat for test.jl be added there too ?

…arkProfiles.jl into tikz-dep-require

github-actions · 2023-11-22T01:41:50Z

Package name	latest	stable
SolverBenchmark.jl

tmigot

Looks good, thanks @d-monnet ! (Please don't forget to ''squash and merge'')

Makes TikzPictures.jl a requirement for using export_performance_prof…

840b779

…ile_tikz

d-monnet requested a review from tmigot November 3, 2023 16:31

fix TikzPictures load

1501767

tmigot requested changes Nov 6, 2023

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

update Project.toml

8f39961

remove unecessary pkg specification in tests

tmigot reviewed Nov 7, 2023

View reviewed changes

src/BenchmarkProfiles.jl Outdated Show resolved Hide resolved

src/BenchmarkProfiles.jl Outdated Show resolved Hide resolved

Apply suggestions from code review

24f1abb

d-monnet added 2 commits November 7, 2023 14:39

add Project.toml to test folder

c089cb2

Merge branch 'tikz-dep-require' of https://github.com/d-monnet/Benchm…

287d418

…arkProfiles.jl into tikz-dep-require

white background for legend box

62ffedb

tmigot added 2 commits November 17, 2023 18:37

remove using

bdebff1

Add ref to package TikzPictures

43154c0

tmigot requested changes Nov 17, 2023

View reviewed changes

d-monnet added 2 commits November 21, 2023 20:30

add deps in tests' Project.toml

cc85b0b

Merge branch 'tikz-dep-require' of https://github.com/d-monnet/Benchm…

f99bd6a

…arkProfiles.jl into tikz-dep-require

tmigot approved these changes Nov 22, 2023

View reviewed changes

d-monnet merged commit 03e00f5 into JuliaSmoothOptimizers:main Nov 22, 2023
16 of 18 checks passed

d-monnet deleted the tikz-dep-require branch November 22, 2023 19:19

d-monnet mentioned this pull request Nov 22, 2023

TikzPictures.jl as optional dep #108

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TikzPictures.jl requirement #110

TikzPictures.jl requirement #110

d-monnet commented Nov 3, 2023

d-monnet commented Nov 3, 2023 •

edited

Loading

github-actions bot commented Nov 3, 2023

d-monnet commented Nov 3, 2023

github-actions bot commented Nov 3, 2023

tmigot left a comment

d-monnet commented Nov 6, 2023

codecov bot commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023

tmigot left a comment

github-actions bot commented Nov 7, 2023

tmigot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

d-monnet commented Nov 7, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

tmigot left a comment

tmigot Nov 17, 2023

d-monnet Nov 21, 2023 •

edited

Loading

tmigot Nov 21, 2023

d-monnet Nov 22, 2023

github-actions bot commented Nov 22, 2023

tmigot left a comment

TikzPictures.jl requirement #110

TikzPictures.jl requirement #110

Conversation

d-monnet commented Nov 3, 2023

d-monnet commented Nov 3, 2023 • edited Loading

github-actions bot commented Nov 3, 2023

d-monnet commented Nov 3, 2023

github-actions bot commented Nov 3, 2023

tmigot left a comment

Choose a reason for hiding this comment

d-monnet commented Nov 6, 2023

codecov bot commented Nov 6, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 6, 2023

tmigot left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2023

tmigot commented Nov 7, 2023

github-actions bot commented Nov 7, 2023

d-monnet commented Nov 7, 2023

github-actions bot commented Nov 13, 2023

github-actions bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

tmigot left a comment

Choose a reason for hiding this comment

tmigot Nov 17, 2023

Choose a reason for hiding this comment

d-monnet Nov 21, 2023 • edited Loading

Choose a reason for hiding this comment

tmigot Nov 21, 2023

Choose a reason for hiding this comment

d-monnet Nov 22, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 22, 2023

tmigot left a comment

Choose a reason for hiding this comment

d-monnet commented Nov 3, 2023 •

edited

Loading

codecov bot commented Nov 6, 2023 •

edited

Loading

d-monnet Nov 21, 2023 •

edited

Loading